Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34185 )
Change subject: mb/asus/p8h61-m_pro: Add comment about PCH GPIO46 ......................................................................
mb/asus/p8h61-m_pro: Add comment about PCH GPIO46
GPIO46 is wired to a tiny switch on the board labelled "GPU Boost". Since coreboot could make use of it, add a comment about it on gpio.c.
Change-Id: I0efa85e6d8235711521b10e56b7c89a25c4b2b7f Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p8h61-m_pro/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/34185/1
diff --git a/src/mainboard/asus/p8h61-m_pro/gpio.c b/src/mainboard/asus/p8h61-m_pro/gpio.c index 1cf848f..b1b819e 100644 --- a/src/mainboard/asus/p8h61-m_pro/gpio.c +++ b/src/mainboard/asus/p8h61-m_pro/gpio.c @@ -105,7 +105,7 @@ .gpio43 = GPIO_MODE_NATIVE, .gpio44 = GPIO_MODE_NATIVE, .gpio45 = GPIO_MODE_NATIVE, - .gpio46 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_GPIO, /* wired to GPU Boost switch */ .gpio47 = GPIO_MODE_NATIVE, .gpio48 = GPIO_MODE_NATIVE, .gpio49 = GPIO_MODE_GPIO,
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34185 )
Change subject: mb/asus/p8h61-m_pro: Add comment about PCH GPIO46 ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34185 )
Change subject: mb/asus/p8h61-m_pro: Add comment about PCH GPIO46 ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34185 )
Change subject: mb/asus/p8h61-m_pro: Add comment about PCH GPIO46 ......................................................................
mb/asus/p8h61-m_pro: Add comment about PCH GPIO46
GPIO46 is wired to a tiny switch on the board labelled "GPU Boost". Since coreboot could make use of it, add a comment about it on gpio.c.
Change-Id: I0efa85e6d8235711521b10e56b7c89a25c4b2b7f Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34185 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/asus/p8h61-m_pro/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/asus/p8h61-m_pro/gpio.c b/src/mainboard/asus/p8h61-m_pro/gpio.c index 1cf848f..b1b819e 100644 --- a/src/mainboard/asus/p8h61-m_pro/gpio.c +++ b/src/mainboard/asus/p8h61-m_pro/gpio.c @@ -105,7 +105,7 @@ .gpio43 = GPIO_MODE_NATIVE, .gpio44 = GPIO_MODE_NATIVE, .gpio45 = GPIO_MODE_NATIVE, - .gpio46 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_GPIO, /* wired to GPU Boost switch */ .gpio47 = GPIO_MODE_NATIVE, .gpio48 = GPIO_MODE_NATIVE, .gpio49 = GPIO_MODE_GPIO,
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)