Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: gma baytrail: Add connectors support ......................................................................
Patch Set 51:
(3 comments)
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-connectors.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 108: Panel.Off (Port_Cfg.Panel);
VGA should probably be disabled here already.
What do you mean? Disable VGA early?
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-soc-hdmi.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 31: VLV_HDMI_VSYNC_NULL_INFOFRAME : constant := 1 * 2 ** 9; -- Needs to be enabled for HDMI
The comment is irritating, I guess it means it's needed for […]
Will drop the comment
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 38: VLV_HDMI_MASK : constant Word32 := 16#ffff_ffff#;
That masking instead of a full register write below was from very […]
Good point.
-
Angel Pons (Code Review)