Change in ...coreboot[master]: lenovo/x230: introduce FHD variant - coreboot-gerrit

22 Jan 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 5:
(1 comment)
Needed a manual rebase :(
Other than that, there is something worth noting.
https://review.coreboot.org/#/c/28950/4/src/mainboard/lenovo/x230/Kconfig 
File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/#/c/28950/4/src/mainboard/lenovo/x230/Kconfig@19 
PS4, Line 19: 	select SANDYBRIDGE_IVYBRIDGE_LVDS if BOARD_LENOVO_X230
This Kconfig option was removed, thus this was dropped. However, GFX_GMA_INTERNAL_IS_LVDS may not make sense for Nitrocaster.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kilian Neuner cb@9-r.net
Gerrit-CC: Sergey Alirzaev zl29ah@gmail.com
Gerrit-CC: Tom Hiller thrilleratplay@gmail.com
Gerrit-Comment-Date: Tue, 22 Jan 2019 09:35:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment