Change in coreboot[master]: mb/google/octopus: Disable Ambient Light Sensor (ALS)

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

25 Sep 2020 25 Sep '20

6:39 p.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

mb/google/octopus: Disable Ambient Light Sensor (ALS)

ALS is not stuffed in octopus boards. Hence disable ALS ACPI devices.

BUG=b:169245831 TEST=Ensure that ALS devices are disabled in ACPI tables.

Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45741/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h index ecc9355..fa86170f 100644 --- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h @@ -54,9 +54,6 @@ * ACPI related definitions for ASL code. */

-/* Enable EC backed ALS device in ACPI */ -#define EC_ENABLE_ALS_DEVICE - /* Enable LID switch and provide wake pin for EC */ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Angel Pons (Code Review)

28 Sep 28 Sep

11:36 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Sep 2020 21:36:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Gwendal Grignou (Code Review)

29 Sep 29 Sep

12:34 a.m.

Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Sep 2020 22:34:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:13 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45741/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45741/1//COMMIT_MSG@11 PS1, Line 11: BUG=b:169245831 BRANCH=octopus?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Sep 2020 23:13:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

1:28 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Angel Pons, Marco Chen, Gwendal Grignou, Gwendal Grignou,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45741

to look at the new patch set (#2).

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

mb/google/octopus: Disable Ambient Light Sensor (ALS)

ALS is not stuffed in octopus boards. Hence disable ALS ACPI devices.

BUG=b:169245831 BRANCH=octopus TEST=Ensure that ALS devices are disabled in ACPI tables.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45741/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

1:29 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45741/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45741/1//COMMIT_MSG@11 PS1, Line 11: BUG=b:169245831

...

BRANCH=octopus?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Sep 2020 23:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:35 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Sep 2020 23:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9 Oct 9 Oct

4:41 p.m.

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45741 )

Change subject: mb/google/octopus: Disable Ambient Light Sensor (ALS) ......................................................................

mb/google/octopus: Disable Ambient Light Sensor (ALS)

ALS is not stuffed in octopus boards. Hence disable ALS ACPI devices.

BUG=b:169245831 BRANCH=octopus TEST=Ensure that ALS devices are disabled in ACPI tables.

Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45741 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h 1 file changed, 0 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h index ecc9355..fa86170 100644 --- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h @@ -54,9 +54,6 @@ * ACPI related definitions for ASL code. */

-/* Enable EC backed ALS device in ACPI */ -#define EC_ENABLE_ALS_DEVICE - /* Enable LID switch and provide wake pin for EC */ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE

-- To view, visit https://review.coreboot.org/c/coreboot/+/45741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad28f01b0515a41b314116eb2d05c520df0f86e Gerrit-Change-Number: 45741 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org Gerrit-Reviewer: Gwendal Grignou gwendal@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1559

days inactive

1573

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Furquan Shaikh (Code Review)
Gwendal Grignou (Code Review)
Karthik Ramasubramanian (Code Review)