Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33762
Change subject: _WIP_ soc/amd/common: Add new GPIO pull-up definition ......................................................................
_WIP_ soc/amd/common: Add new GPIO pull-up definition
todo: incorporate into a macro?
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: If24bed8b3f10d945b9988445025409c8420dd07a --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/33762/1
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h index da84134..a415d35 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h @@ -59,6 +59,7 @@ #define GPIO_S4_S5_WAKE_EN (1 << 15)
#define GPIO_PIN_STS (1 << 16) +#define GPIO_8KPULLUP_SELECT (1 << 19) #define GPIO_PULLUP_ENABLE (1 << 20) #define GPIO_PULLDOWN_ENABLE (1 << 21) #define GPIO_OUTPUT_SHIFT 22
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33762 )
Change subject: _WIP_ soc/amd/common: Add new GPIO pull-up definition ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33762/1//COMMIT_MSG@9 PS1, Line 9: incorporate Most definitely.
Hello Richard Spiegel, build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33762
to look at the new patch set (#9).
Change subject: soc/amd/common: Add new GPIO 8K pull-up definition ......................................................................
soc/amd/common: Add new GPIO 8K pull-up definition
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: If24bed8b3f10d945b9988445025409c8420dd07a --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/33762/9
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33762 )
Change subject: soc/amd/common: Add new GPIO 8K pull-up definition ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33762/1//COMMIT_MSG@9 PS1, Line 9: incorporate
Most definitely.
Done
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33762 )
Change subject: soc/amd/common: Add new GPIO 8K pull-up definition ......................................................................
Patch Set 9: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33762 )
Change subject: soc/amd/common: Add new GPIO 8K pull-up definition ......................................................................
soc/amd/common: Add new GPIO 8K pull-up definition
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: If24bed8b3f10d945b9988445025409c8420dd07a Reviewed-on: https://review.coreboot.org/c/coreboot/+/33762 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h index da84134..6427cb6 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h @@ -59,6 +59,7 @@ #define GPIO_S4_S5_WAKE_EN (1 << 15)
#define GPIO_PIN_STS (1 << 16) +#define GPIO_8KPULLUP_SELECT (1 << 19) #define GPIO_PULLUP_ENABLE (1 << 20) #define GPIO_PULLDOWN_ENABLE (1 << 21) #define GPIO_OUTPUT_SHIFT 22 @@ -107,6 +108,7 @@ #define GPIO_OUTPUT_OUT_HIGH (GPIO_OUTPUT_ENABLE | GPIO_OUTPUT_VALUE) #define GPIO_OUTPUT_OUT_LOW GPIO_OUTPUT_ENABLE
+#define GPIO_PULL_PULL_UP_8K (GPIO_PULLUP_ENABLE | GPIO_8KPULLUP_SELECT) #define GPIO_PULL_PULL_UP GPIO_PULLUP_ENABLE #define GPIO_PULL_PULL_DOWN GPIO_PULLDOWN_ENABLE #define GPIO_PULL_PULL_NONE 0
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)
-
Richard Spiegel (Code Review)