Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46120 )
Change subject: mb/google/poppy/variant/atlas: Reset bluetooth in BIOS ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@7 PS1, Line 7: mb/google/poppy/variant/atlas: Reset bluetooth in BIOS Please avoid the term BIOS at least in summaries. ;-)
As it’s a coreboot commit, one could argue it’s redundant, but maybe:
Reset Bluetooth chip in coreboot
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@13 PS1, Line 13: down-rev Sorry, what does that mean?
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@14 PS1, Line 14: makes no attempt update *to* update
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@12 PS1, Line 12: If the BT chip is : already running down-rev firmware from a previous boot, the driver : makes no attempt update the BT firmware by resetting it. This can lead : to unexpected behavior across system upgrades. Is there a Linux bug report for that issue?
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@17 PS1, Line 17: Please describe the change.
As the infrastructure is in coreboot, only add the GPIO to …
(or something similar)
-
Paul Menzel (Code Review)