Attention is currently required from: Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59834 )
Change subject: lib: Fix edge case of log2_ceil()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Could log2(x - 1) + 1 achieve the same without casting to 64 bits? That would make this more efficient on x86.
Also, please keep the libpayload version in sync with this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e
Gerrit-Change-Number: 59834
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 19:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment