Change in coreboot[master]: payloads/LinuxBoot: Fix initramfs Makefile rule

List overview All Threads
Download

newer

older

[L] Change in coreboot[master]:...

Change in coreboot[master]:...

Patrick Rudolph (Code Review)

23 Jan 2020 23 Jan '20

1:12 p.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

payloads/LinuxBoot: Fix initramfs Makefile rule

Pass $(top) to LinuxBoot Makefile and build u-root before trying to include it into uImage on aarch64.

Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 2 files changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38530/1

diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index 5840e8e..67bb730 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -62,7 +62,10 @@ fi endif

-linuxboot: kernel initramfs_compressed +linuxboot: + # for AARCH64 uroot needs to be build first + $(MAKE) initramfs_compressed + $(MAKE) kernel

clean: if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index b8af8c9..4388a9e 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -295,7 +295,8 @@ CONFIG_LINUXBOOT_UROOT_SHELL=$(CONFIG_LINUXBOOT_UROOT_SHELL) \ CONFIG_LINUXBOOT_UROOT_COMMANDS=$(CONFIG_LINUXBOOT_UROOT_COMMANDS) \ CONFIG_LINUXBOOT_UROOT_FILES=$(CONFIG_LINUXBOOT_UROOT_FILES) \ - CONFIG_LINUXBOOT_DTB_FILE=$(CONFIG_LINUXBOOT_DTB_FILE) + CONFIG_LINUXBOOT_DTB_FILE=$(CONFIG_LINUXBOOT_DTB_FILE) \ + top=$(top)

payloads/external/LinuxBoot/linuxboot/bzImage: linuxboot payloads/external/LinuxBoot/linuxboot/uImage: linuxboot

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Patrick Rudolph (Code Review)

24 Jan 24 Jan

7:04 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38530

to look at the new patch set (#2).

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

payloads/LinuxBoot: Fix initramfs Makefile rule

Pass $(top) to LinuxBoot Makefile and build u-root before trying to include it into uImage on aarch64.

Fixes build on aarch64.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38530/2

Patrick Georgi (Code Review)

28 Jan 28 Jan

9:40 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... PS2, Line 65: linuxboot: kernel initramfs_compressed could this be

linuxboot: kernel initramfs_compressed kernel: initramfs_compressed

? That should also enforce the order without serializing via calling sub-makes (which seems hackish to me)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer marcello.bauer@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jan 2020 21:40:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

30 Jan 30 Jan

9:35 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... PS2, Line 65: linuxboot: kernel initramfs_compressed

...

could this be […]

there's a dependency on "initramfs" above, maybe it's racing only on the compression part?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 30 Jan 2020 21:35:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Marcello Sylvester Bauer (Code Review)

27 Jul 27 Jul

4:36 p.m.

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 16:36:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:44 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38530/4/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/c/coreboot/+/38530/4/payloads/external/LinuxBoot... PS4, Line 47: initramfs isn't it enough to change this to initramfs_compressed instead of doing the sub-makes at line 67+?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 16:44:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4:46 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 4:

(1 comment)

There's an open comment

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/c/coreboot/+/38530/2/payloads/external/LinuxBoot... PS2, Line 65: linuxboot: kernel initramfs_compressed

...

there's a dependency on "initramfs" above, maybe it's racing only on the compression part?

*poke*

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 16:46:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

28 Jul 28 Jul

4:24 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jul 2020 16:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10 Aug 10 Aug

10:46 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38530 )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38530/4/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/c/coreboot/+/38530/4/payloads/external/LinuxBoot... PS4, Line 66: uroot u-root

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 10:46:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:18 p.m.

New subject: [XS] Change in coreboot[master]: payloads/LinuxBoot: Fix initramfs Makefile rule

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38530?usp=email )

Change subject: payloads/LinuxBoot: Fix initramfs Makefile rule ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d037a24b2893455761912fc966aa02272ad070 Gerrit-Change-Number: 38530 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin L Roth gaumless@gmail.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

478

days inactive

1770

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Marcello Sylvester Bauer (Code Review)
Martin L Roth (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)