Change in coreboot[master]: mb/google/nipperkin: Fix WLAN to GEN2 speed - coreboot-gerrit

20 Apr 2022


      Attention is currently required from: Bao Zheng, Raul Rangel, Rob Barnes, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63722 )
Change subject: mb/google/nipperkin: Fix WLAN to GEN2 speed
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63722/comment/8a82bbee_eb04c7e0 
PS1, Line 10: during S0ix suspend
Where exactly?
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63722/comment/dfe55763_e884ee94 
PS1, Line 14: 	dxio_descriptors[WLAN].port_params[1] = 0x122;
What does 0x122 mean? Add a comment?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I988365e51aca0d6515c5605b3032521cf59d8d30
Gerrit-Change-Number: 63722
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Patrick Huang patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 05:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment