Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/30117/13/src/arch/x86/idt.S
File src/arch/x86/idt.S:
https://review.coreboot.org/#/c/30117/13/src/arch/x86/idt.S@131
PS13, Line 131: */
Perhaps SS should be listed as well.
https://review.coreboot.org/#/c/30117/13/src/arch/x86/idt.S@159
PS13, Line 159: pop %rax
Stack was aligned two instructions earlier, this pops wrong values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Apr 2019 12:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment