Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36589 )
Change subject: cpu/x86/smm: Add helper functions to deal with different save states ......................................................................
Patch Set 3:
Patch Set 3:
We have something similar in src/soc/intel/common/block/include/intelblocks/smihandler.h and src/soc/intel/common/block/smm/smihandler.c where the ops are about getting and setting a register.
- Why is this about pointers to registers and not just getting and setting the explicit register?
- I prefer the ops-based approach because the chipset can say "these are my ops" and the other save state versions are garbage collected instead of carrying support for save state versions in the binary.
- Are we planning on converging/sharing the implementation?
Attempt to provide an API in CB:36661. With that code there is no need anymore to have per chipset ops, since the ops can be guessed from the smm revision.