Change in coreboot[master]: soc/amd/picasso/Makefile: Change APCB_magic.bin location

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Raul Rangel (Code Review)

26 May 2020 26 May '20

2:36 p.m.

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

soc/amd/picasso/Makefile: Change APCB_magic.bin location

The APCB_magic.bin lives in amd_blobs, not blobs.

BUG=b:157140753 TEST=Boot trembyle to OS

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/41734/1

diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index e1416bc..05d46ea 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -289,7 +289,7 @@ cp $< $@

# APCB binary with magic numbers to be replaced by apcb_edit tool -APCB_MAGIC_BLOB:=$(MAINBOARD_BLOBS_DIR)/APCB_magic.bin +APCB_MAGIC_BLOB:=$(FIRMWARE_LOCATE)/APCB_magic.bin

$(obj)/APCB_empty.bin: $(APCB_MAGIC_BLOB) $(APCB_EDIT_TOOL) $(APCB_EDIT_TOOL) \

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Felix Held (Code Review)

26 May 26 May

2:40 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Patch Set 1: Code-Review+2

i wonder if we should wait with submitting this until the blob is merged and the submodule pointer is updated

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 26 May 2020 17:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Raul Rangel (Code Review)

2:45 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Patch Set 1:

...

Patch Set 1: Code-Review+2

i wonder if we should wait with submitting this until the blob is merged and the submodule pointer is updated

Either or, it doesn't build upstream currently, so not sure it matters.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 26 May 2020 17:45:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

4:16 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Uploaded patch set 2: Patch Set 1 was rebased.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 26 May 2020 19:16:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

5:50 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Uploaded patch set 3: Patch Set 2 was rebased.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 26 May 2020 20:50:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

27 May 27 May

3:25 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 May 2020 06:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Raul Rangel (Code Review)

2:26 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Uploaded patch set 4: Patch Set 3 was rebased.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 17:26:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

4:18 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

soc/amd/picasso/Makefile: Change APCB_magic.bin location

The APCB_magic.bin lives in amd_blobs, not blobs.

BUG=b:157140753 TEST=Boot trembyle to OS

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41734 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Furquan Shaikh: Looks good to me, approved

# APCB binary with magic numbers to be replaced by apcb_edit tool -APCB_MAGIC_BLOB:=$(MAINBOARD_BLOBS_DIR)/APCB_magic.bin +APCB_MAGIC_BLOB:=$(FIRMWARE_LOCATE)/APCB_magic.bin

$(obj)/APCB_empty.bin: $(APCB_MAGIC_BLOB) $(APCB_EDIT_TOOL) $(APCB_EDIT_TOOL) \

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

4:31 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )

Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location ......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4214 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4213 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4212 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4211

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41 Gerrit-Change-Number: 41734 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 19:31:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1791

days inactive

1792

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
Raul Rangel (Code Review)