Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55148 )
Change subject: mb/google/guybrush/var/guybrush: Update GPIO configuration ......................................................................
mb/google/guybrush/var/guybrush: Update GPIO configuration
Some of the GPIOs are either re-purposed for different use-cases or are unused in upcoming board phase (board version 2). Update the GPIO configuration accordingly. Here are the GPIOs that are updated: GPIO Board Id 1 Board Id 2 ============================================= GPIO31 TP183 EN_SPKR GPIO69 EN_SPKR SD_AUX_REST_L GPIO70 SD_AUX_RESET_L Unused TP27 GPIO74 RAM_ID_CHAN_SEL Unused TP49
BUG=b:189327557, b:188542649, b:188542497 TEST=Build Guybrush mainboard.
Change-Id: I31523b3e03d2b59577f33eae548747834cfc98aa Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c M src/mainboard/google/guybrush/variants/guybrush/gpio.c 2 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/55148/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index c89ded2..af19e50 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -64,8 +64,8 @@ PAD_GPO(GPIO_29, LOW), /* ESPI_CS_L */ PAD_NF(GPIO_30, ESPI_CS_L, PULL_NONE), - /* SPI_CS3_L */ - PAD_NF(GPIO_31, SPI_CS3_L, PULL_NONE), + /* EN_SPKR */ + PAD_GPO(GPIO_31, HIGH), /* EN_PWR_FP */ PAD_GPO(GPIO_32, HIGH), /* GPIO_33 - GPIO_39: Not available */ @@ -79,13 +79,11 @@ PAD_GPI(GPIO_67, PULL_NONE), /* EN_PP3300_TCHSCR */ PAD_GPO(GPIO_68, LOW), - /* EN_SPKR */ - PAD_GPO(GPIO_69, HIGH), /* SD_AUX_RESET_L */ - PAD_GPO(GPIO_70, HIGH), + PAD_GPO(GPIO_69, HIGH), + /* GPIO_70 Unused TP27 */ /* GPIO_71 - GPIO_73: Not available */ - /* RAM_ID_CHAN_SEL */ - PAD_GPI(GPIO_74, PULL_NONE), + /* GPIO_74 Unused TP49 */ /* RAM_ID_2 / DEV_BEEP_LRCLK */ PAD_GPI(GPIO_75, PULL_NONE), /* EN_PP3300_CAM */ diff --git a/src/mainboard/google/guybrush/variants/guybrush/gpio.c b/src/mainboard/google/guybrush/variants/guybrush/gpio.c index 64afa60..3ca77f7 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/gpio.c +++ b/src/mainboard/google/guybrush/variants/guybrush/gpio.c @@ -8,8 +8,14 @@
/* This table is used by guybrush variant with board version < 2. */ static const struct soc_amd_gpio bid1_gpio_table[] = { + /* SPI_CS3_L */ + PAD_NF(GPIO_31, SPI_CS3_L, PULL_NONE), /* EN_SPKR */ - PAD_GPO(GPIO_69, LOW), + PAD_GPO(GPIO_69, HIGH), + /* SD_AUX_RESET_L */ + PAD_GPO(GPIO_70, HIGH), + /* RAM_ID_CHAN_SEL */ + PAD_GPI(GPIO_74, PULL_NONE), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)