Attention is currently required from: Felix Held.
Hello Marshall Dawson, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79985?usp=email
to look at the new patch set (#4).
Change subject: soc/amd/genoa_poc: rely less on boot state hooks ......................................................................
soc/amd/genoa_poc: rely less on boot state hooks
Call setup_opensil, opensil_entry, and fch_init in the right order from the init method of the SoC's chip operations. This brings this SoC both more in line with the other SoCs and avoids using boot state hooks for this which also makes the sequence in which those functions are called easier to understand. Previously the boot states were used so that setup_opensil was run before configure_mpio which was run before opensil_entry(SIL_TP1), but since configure_mpio is called from setup_opensil, this is no longer necessary.
TEST=Onyx still boots to the payload and the MPIO configuration reported from the openSIL code is still the same. The FCH init code now runs before the resource allocation like on the AMD SoCs that rely on FSP.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic752635da5eaa9e333cfb927836f0d260d2ac049 --- M src/soc/amd/genoa_poc/chip.c M src/soc/amd/genoa_poc/fch.c M src/soc/amd/genoa_poc/include/soc/southbridge.h M src/vendorcode/amd/opensil/genoa_poc/opensil.h M src/vendorcode/amd/opensil/genoa_poc/ramstage.c 5 files changed, 16 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/79985/4