Attention is currently required from: Eren Peng, Ivan Chen, Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Just want to clarify how we would like to manage it on brox. […]
I understand what you're saying. I personally don't have a strong preference to keeping the fw_config definitions out of baseboard. I cc'ed Nick though. I think that he mentioned when brox started out that he preferred having the fw_config bits in the variant so that all variants didn't have to have the CBI fields in the same bits. Nick, what do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 2
Gerrit-Owner: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
hsueh.rasheed@inventec.corp-partner.google.com
Gerrit-CC: Steven Yeh
yeh.stevenct@inventec.corp-partner.google.com
Gerrit-Attention: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Thu, 11 Apr 2024 22:44:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Ivan Chen
yulunchen@google.com
Gerrit-MessageType: comment