Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48203
to review the following change.
Change subject: mb/zork: set APU_EDP_BL_DISABLE to low as default ......................................................................
mb/zork: set APU_EDP_BL_DISABLE to low as default
set APU_EDP_BL_DISABLE(GPIO_85) to low to avoid the VARY_BL fast than APU_DP_BLON.
BUG=b:171954512 BRANCH=zork TEST=validate the panel sequence with scope.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ia6d3f4335583bb2d91a6bce96d89cff84247d0ad --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/48203/1
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c index 884862d..e928d8c 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c @@ -95,8 +95,8 @@ /* GPIO_77 - GPIO_83: Not available */ /* HP_INT_ODL */ PAD_GPI(GPIO_84, PULL_NONE), - /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */ - PAD_GPO(GPIO_85, HIGH), + /* APU_EDP_BL_DISABLE */ + PAD_GPO(GPIO_85, LOW), /* RAM ID 2 - Keep High */ PAD_GPO(GPIO_86, HIGH), /* EMMC_DATA7 */ diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index 818c39b..bb99f5d 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -99,8 +99,8 @@ /* GPIO_77 - GPIO_83: Not available */ /* RAM_ID_4 */ PAD_GPI(GPIO_84, PULL_NONE), - /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */ - PAD_GPO(GPIO_85, HIGH), + /* APU_EDP_BL_DISABLE */ + PAD_GPO(GPIO_85, LOW), /* WIFI_AUX_RESET_L */ PAD_GPO(GPIO_86, HIGH), /* EMMC_DATA7 */
Hello Chris Wang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48203
to look at the new patch set (#2).
Change subject: mb/google/zork: set APU_EDP_BL_DISABLE to low as default ......................................................................
mb/google/zork: set APU_EDP_BL_DISABLE to low as default
set APU_EDP_BL_DISABLE(GPIO_85) to low to avoid the VARY_BL fast than APU_DP_BLON.
BUG=b:171954512 BRANCH=zork TEST=validate the panel sequence with scope.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ia6d3f4335583bb2d91a6bce96d89cff84247d0ad --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/48203/2
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48203 )
Change subject: mb/google/zork: set APU_EDP_BL_DISABLE to low as default ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48203 )
Change subject: mb/google/zork: set APU_EDP_BL_DISABLE to low as default ......................................................................
mb/google/zork: set APU_EDP_BL_DISABLE to low as default
set APU_EDP_BL_DISABLE(GPIO_85) to low to avoid the VARY_BL fast than APU_DP_BLON.
BUG=b:171954512 BRANCH=zork TEST=validate the panel sequence with scope.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ia6d3f4335583bb2d91a6bce96d89cff84247d0ad Reviewed-on: https://review.coreboot.org/c/coreboot/+/48203 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kangheui Won khwon@chromium.org --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kangheui Won: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c index a528827..bf27abf 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c @@ -95,8 +95,8 @@ /* GPIO_77 - GPIO_83: Not available */ /* HP_INT_ODL */ PAD_GPI(GPIO_84, PULL_NONE), - /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */ - PAD_GPO(GPIO_85, HIGH), + /* APU_EDP_BL_DISABLE */ + PAD_GPO(GPIO_85, LOW), /* RAM ID 2 - Keep High */ PAD_GPO(GPIO_86, HIGH), /* EMMC_DATA7 */ diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index 2929c54..0745eda 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -99,8 +99,8 @@ /* GPIO_77 - GPIO_83: Not available */ /* RAM_ID_4 */ PAD_GPI(GPIO_84, PULL_NONE), - /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */ - PAD_GPO(GPIO_85, HIGH), + /* APU_EDP_BL_DISABLE */ + PAD_GPO(GPIO_85, LOW), /* WIFI_AUX_RESET_L */ PAD_GPO(GPIO_86, HIGH), /* EMMC_DATA7 */
-
chris wang (Code Review) -
Kangheui Won (Code Review)
-
Patrick Georgi (Code Review)