Attention is currently required from: Chen, Gang C, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, Shuo Liu, TangYiwei, Varshit Pandya.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )
Change subject: mb/intel/avenuecity_crb: Add 2S GNR/SRF-AP server board Avenue City ......................................................................
Patch Set 31:
(6 comments)
File src/mainboard/intel/avenuecity_crb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/81319/comment/0f1618e8_0242e0e9 : PS31, Line 5: #include <device/pci_def.h> : #include <device/pci_ops.h> unused?
https://review.coreboot.org/c/coreboot/+/81319/comment/4059d5e6_65f99edf : PS31, Line 9: #include <soc/pci_devs.h> unused?
https://review.coreboot.org/c/coreboot/+/81319/comment/7ad44eaa_bc94016a : PS31, Line 21: CONFIG_ASPEED_SIO_PORT Does this need to be a Kconfig?
File src/mainboard/intel/avenuecity_crb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81319/comment/83f7e26d_a76ebbb5 : PS31, Line 16: register "gen2_dec" = "0x0" : register "gen3_dec" = "0x0" : register "gen4_dec" = "0x0" 0 is default so no need to set it explicitly
https://review.coreboot.org/c/coreboot/+/81319/comment/4d9347a6_ab7a3eae : PS31, Line 21: register "serial_io_uart_debug_io_base" = "0x3F8" Can't CONFIG_TTYS0_BASE be reused?
File src/mainboard/intel/avenuecity_crb/include/config/iio.h:
https://review.coreboot.org/c/coreboot/+/81319/comment/c1df3b60_18d357d4 : PS31, Line 8: static const iio_pe_config avc_iio_config_table[] = { : {_IIO_PE_CFG_STRUCT(0x0, PE0, IIO_BIFURCATE_x2x2x2x2x8, PE_TYPE_PCIE) { : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x4B, 0x1), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x4B, 0x2), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x4B, 0x3), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x4B, 0x4), : _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, : 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x4B, 0x5) : }}, : }; : move to romstage.c file? Data structures in a header is not a good idea.