Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54133 )
Change subject: ec/google/chromeec: Implement support for DRIVERS_ACPI_THERMAL_ZONE ......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/54133/comment/50dbc280_ef1c25c1 PS2, Line 267: : void google_chromeec_acpigen_write_TMP(const struct device *dev) : { : struct drivers_acpi_thermal_zone_config *config = config_of(dev); : static char buf[DEVICE_PATH_MAX] = {}; : const char *ec_path = acpi_device_path(config->temperature_controller); : : /* : * The cros EC device returns EC0.CREC as the acpi_name. The method : * we want is on the EC0 device. : */ : snprintf(buf, sizeof(buf), "%.*s.TSRD", strlen(ec_path) - 5, : acpi_device_path(config->temperature_controller)); : : acpigen_write_method_serialized("_TMP", 0); : : acpigen_emit_byte(RETURN_OP); : acpigen_emit_namestring(buf); : acpigen_write_integer(config->sensor_id); : : acpigen_write_method_end(); : }
consider a refactor? https://review.coreboot. […]
Can we inject the EC0 device into the device tree at runtime? I'm not sure how complicated it is to update all the pointers though...