Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86305?usp=email )
Change subject: ec/starlabs/merlin: Add an option to disabled the lid switch ......................................................................
ec/starlabs/merlin: Add an option to disabled the lid switch
Previously, the lid switch could be set to not wake the system.
Add another option to ignore the switch entirely.
Change-Id: I1dd666a44b332ffbbef4420799eeffd746fd1664 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86305 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starfighter/cfr.c M src/mainboard/starlabs/starlite_adl/cfr.c 3 files changed, 12 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/cfr.c b/src/mainboard/starlabs/starbook/cfr.c index 9b47f483..bf0e4b0 100644 --- a/src/mainboard/starlabs/starbook/cfr.c +++ b/src/mainboard/starlabs/starbook/cfr.c @@ -126,11 +126,12 @@ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif diff --git a/src/mainboard/starlabs/starfighter/cfr.c b/src/mainboard/starlabs/starfighter/cfr.c index 7c8a123..f310f86 100644 --- a/src/mainboard/starlabs/starfighter/cfr.c +++ b/src/mainboard/starlabs/starfighter/cfr.c @@ -108,11 +108,12 @@ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif diff --git a/src/mainboard/starlabs/starlite_adl/cfr.c b/src/mainboard/starlabs/starlite_adl/cfr.c index 58a09a3..a8e44fa 100644 --- a/src/mainboard/starlabs/starlite_adl/cfr.c +++ b/src/mainboard/starlabs/starlite_adl/cfr.c @@ -73,11 +73,12 @@ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif