Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81333?usp=email )
Change subject: mb/google/rex: Add Intel Touch for controller 1 for Rex
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81333/comment/1649d57a_d66570ae :
PS4, Line 13: minor Rework
Minor rework …
Done
https://review.coreboot.org/c/coreboot/+/81333/comment/d2f8247f_4cf5a693 :
PS4, Line 9: GPIO pad configuration for THC1 according to CBI fw_config.
: ACPI entries in SSDT for ELAN according to CBI fw_config.
:
: THC0 must be enabled when THC1 is enabled.
: Major rework is required for Rex P1 and P2. minor Rework is needed for
: EVT. Rex with THC rework won't be able to support UWB and FPCMU.
: The touch device must be converted to SPI interface.
: When THC is enabled and the THC rework is in place, the UWB and FPMCU
: are not supported and need to be disable from the CBI.
: THC0 will also be provided with ACPI entries when THC1 is enabled.
: THC1 GPIO pins will be configured for THC according to the CBI
: TOUCHSCREEN fw_config field.
: The resistor on the THC-SPI MISO pin should be 100 Ohm.
ok. let me make changes.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81333?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id89b5b46d67b90491410d3d08c1a3ae9549b4da5
Gerrit-Change-Number: 81333
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Jingyuan Liang
jingyliang@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 20:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment