Change in coreboot[master]: mb/google/volteer/v/volteer2: Config for passive USB-C DB on C1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47501 )

Change subject: mb/google/volteer/v/volteer2: Config for passive USB-C DB on C1
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/mainboard.c:

https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... 
PS2, Line 131: x04;	/* port2 retimer disable */
where did this value come from?

https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... 
PS2, Line 146: 
             : 	gpio_configure_pads_with_override(base_pads, base_num,
             : 		override_pads, override_num);
             : 
             : 	if (fw_config_probe(FW_CONFIG(DB_USB, USB3_PASSIVE))) {
             : 		const struct pad_config *pads;
             : 		size_t num;
             : 
             : 		pads = variant_usb3_passive_gpio_table(&num);
             : 		gpio_configure_pads(pads, num);
             : 	}
can this go in mb/google/volteer/fw_config.c instead?

https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... 
PS2, Line 34: 0x090E0016
Where do these values come from?