Attention is currently required from: Christopher Meis, Arthur Heymans. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55513 )
Change subject: intel/fit - Prepare for BootGuard support ......................................................................
Patch Set 1:
(1 comment)
File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55513/comment/575542bc_c27f4795 PS1, Line 16: intel_fit-position := 0xffff0000 # Set position for BootGuard
Where does this requirement come from? reading #558294 I don't see the need for that. […]
#557867 states that those modules "are expected to be" at those location. That's not *must be* IMHO. Chapter 4.3 and 4.4 state that FIT,KM, BPM and ACM can be in the top 8M for CFL.
Did you do tests and can you confirm which of those restrictions are actually true?
I aggree that in any case that would need a proper tooling without hardcoding to many memory ranges in Kconfig.
-
Patrick Rudolph (Code Review)