Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34997 )
Change subject: AGESA,binaryPI: Replace use of __PRE_RAM__ ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34997/1/src/drivers/amd/agesa/def_c... File src/drivers/amd/agesa/def_callouts.c:
https://review.coreboot.org/c/coreboot/+/34997/1/src/drivers/amd/agesa/def_c... PS1, Line 166: return AmdMemoryReadSPD (Func, Data, ConfigPtr);
space prohibited between function name and open parenthesis '('
Ack
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/hudson.h:
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/agesa/h... PS1, Line 63: ugh, this file!
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/fan.h:
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... PS1, Line 19: #include <device/device.h> Was this intentional?
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb900/cfg.c:
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... PS1, Line 247: if (ENV_RAMSTAGE && !sb_config->StdHeader.CALLBACK.CalloutPtr) {
braces {} are not necessary for single statement blocks
Ack
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... PS1, Line 252: printk(BIOS_INFO, "SB900 - Cfg.c - sb900_cimx_config - End.\n");
Prefer using '"%s... […]
Ack
-
Marshall Dawson (Code Review)