Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier.
Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/common/cpu/noncar: Compute core info ......................................................................
Patch Set 10:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85640/comment/da40626d_51369b3b?usp... : PS9, Line 22:
Sure.
Done
File src/soc/amd/glinda/cpu.c:
PS9:
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/9173ba75_1e2dbe13?usp... : PS9, Line 22: get
ack
Update as ap_stash_core_info because it will also be used to get max boost frequency along with L3 cache info.
https://review.coreboot.org/c/coreboot/+/85640/comment/1830e147_6470a2b9?usp... : PS9, Line 24: 0x8000001e
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/8b9d13ef_41ce9272?usp... : PS9, Line 24: cpuid
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/48fe3821_4797470d?usp... : PS9, Line 27: uint8_t level = 3;
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/92781731_462fdbcf?usp... : PS9, Line 27: 3
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/10a6c85a_eff0cbf5?usp... : PS9, Line 38: 3
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/ed0e224a_014a2bba?usp... : PS9, Line 49: for (int i = 0; i < get_cpu_count(); i++) {
ack
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/03f43823_010a50a6?usp... : PS9, Line 59: }
ack
Done