Change in ...coreboot[master]: superio/wpcm450: fix keyboard IO masks

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Felix Held (Code Review)

16 Jan 2019 16 Jan '19

1:04 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30958

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

superio/wpcm450: fix keyboard IO masks

Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/wpcm450/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/30958/1

diff --git a/src/superio/nuvoton/wpcm450/superio.c b/src/superio/nuvoton/wpcm450/superio.c index fa7a8a0..99abfe4 100644 --- a/src/superio/nuvoton/wpcm450/superio.c +++ b/src/superio/nuvoton/wpcm450/superio.c @@ -47,7 +47,7 @@ { NULL, WPCM450_SP2, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0 | PNP_DRQ1, 0x07f8, }, { NULL, WPCM450_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, WPCM450_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07f8, 0x07f8, }, + { NULL, WPCM450_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07ff, 0x07ff, }, };

static void enable_dev(struct device *dev)

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Paul Menzel (Code Review)

16 Jan 16 Jan

1:09 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30958 )

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG@8 PS1, Line 8: Also add:

...

The IO mask shouldn't contain zeros inside the block of ones.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Jan 2019 13:09:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

1:13 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30958 )

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG@8 PS1, Line 8:

...

Also add: […]

that wasn't the issue here

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Jan 2019 13:13:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:37 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30958 )

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

Patch Set 1: -Code-Review

(1 comment)

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30958/1//COMMIT_MSG@8 PS1, Line 8:

...

that wasn't the issue here

Understood. But what is the issue then?

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Jan 2019 14:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Held (Code Review)

2:59 p.m.

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30958

to look at the new patch set (#2).

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

superio/wpcm450: fix keyboard IO masks

The two IO regions of the keyboard controller are 1 byte long, not 8.

Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/wpcm450/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/30958/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

24 Jan 24 Jan

2:56 a.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30958 )

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 02:56:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

3:01 a.m.

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30958 )

Change subject: superio/wpcm450: fix keyboard IO masks ......................................................................

superio/wpcm450: fix keyboard IO masks

The two IO regions of the keyboard controller are 1 byte long, not 8.

Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/30958 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M src/superio/nuvoton/wpcm450/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved

static void enable_dev(struct device *dev)

-- To view, visit https://review.coreboot.org/c/coreboot/+/30958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7319ce9f84181759f4dc7b59c0020f3a5dd5dc03 Gerrit-Change-Number: 30958 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2136

days inactive

2144

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Felix Held (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)