Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49140 )
Change subject: soc/intel/skylake/acpi: Add PEP table ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: -Code-Review
Patch Set 3: Code-Review-1
Patch Set 3: Code-Review+2
wait... did I really forget SKL? 😮
It was using PMC, not LPIT. Is that a problem?
No, vendor firmware for my Skylake board uses both devices as well. So this seems to be fine?
No, I reworked that. PMC/LPID/LPIT was actually confusing. PEP(D) is the "right" (or more correct) device name for this, so I cleaned this up but obviously forgot to add it to SKL as well 😄
LPIT is related but a (very) different table, though.
Öh oh well, actually that PMC that you mean (src/soc/intel/skylake/acpi/pmc.asl) is the "real" PMC. The "pmc.asl" (iirc the name correctly) was implementing LPID/PEPD. That was what I cleaned up.