Change in ...coreboot[master]: mainboard/facebook/fbg1701/fadt.c: Use asl_revision

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Frans Hendriks (Code Review)

12 Jun 2019 12 Jun '19

6:33 a.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33423

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

mainboard/facebook/fbg1701/fadt.c: Use asl_revision

Fix value of 1 is used for asl_compiler_revision. Use asl_revision for this.

BUG=N/A TEST=booting Linux 4.20 kernel on Facebook FBG1701

Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/fadt.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/33423/1

diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c index 73adfad..7814106 100644 --- a/src/mainboard/facebook/fbg1701/fadt.c +++ b/src/mainboard/facebook/fbg1701/fadt.c @@ -16,6 +16,7 @@ */

#include <soc/acpi.h> +#include <version.h>

void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { @@ -28,7 +29,7 @@ memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); - header->asl_compiler_revision = 1; + header->asl_compiler_revision = asl_revision;

fadt->firmware_ctrl = (unsigned long) facs; fadt->dsdt = (unsigned long) dsdt;

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

HAOUAS Elyes (Code Review)

12 Jun 12 Jun

10:04 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... File src/mainboard/facebook/fbg1701/fadt.c:

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... PS1, Line 28: header->revision = 3 header->revision = get_acpi_table_revision(FADT)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 12 Jun 2019 17:04:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:12 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... File src/mainboard/facebook/fbg1701/fadt.c:

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... PS1, Line 28: header->revision = 3

...

header->revision = get_acpi_table_revision(FADT)

sorry, forget it, I'll send a patch for all remaining mb that use "header->revision = 3"

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 12 Jun 2019 17:12:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:49 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 12 Jun 2019 17:49:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

10:45 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... File src/mainboard/facebook/fbg1701/fadt.c:

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... PS1, Line 28: header->revision = 3

...

sorry, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 13 Jun 2019 05:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

18 Jun 18 Jun

3:37 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... File src/mainboard/facebook/fbg1701/fadt.c:

https://review.coreboot.org/#/c/33423/1/src/mainboard/facebook/fbg1701/fadt.... PS1, Line 28: header->revision = 3

...

Done

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Jun 2019 10:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: comment

Lance Zhao (Code Review)

4:41 p.m.

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Jun 2019 23:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 Jun 21 Jun

1:52 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33423 )

Change subject: mainboard/facebook/fbg1701/fadt.c: Use asl_revision ......................................................................

mainboard/facebook/fbg1701/fadt.c: Use asl_revision

Fix value of 1 is used for asl_compiler_revision. Use asl_revision for this.

BUG=N/A TEST=booting Linux 4.20 kernel on Facebook FBG1701

Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33423 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Lance Zhao lance.zhao@gmail.com --- M src/mainboard/facebook/fbg1701/fadt.c 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Lance Zhao: Looks good to me, approved

diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c index 60dd5b9..544d24b 100644 --- a/src/mainboard/facebook/fbg1701/fadt.c +++ b/src/mainboard/facebook/fbg1701/fadt.c @@ -16,6 +16,7 @@ */

#include <soc/acpi.h> +#include <version.h>

fadt->firmware_ctrl = (unsigned long) facs; fadt->dsdt = (unsigned long) dsdt;

-- To view, visit https://review.coreboot.org/c/coreboot/+/33423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffd8fe637d4669b7099fb6eafc9873560502bf80 Gerrit-Change-Number: 33423 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1976

days inactive

1985

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
HAOUAS Elyes (Code Review)
Lance Zhao (Code Review)
Patrick Georgi (Code Review)