Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34853 )
Change subject: mb/google/kukui: Report panel manufacturer name ......................................................................
mb/google/kukui: Report panel manufacturer name
The src/lib/edid now supports reporting manufacturer name so we should define that in MIPI panels and print out in initialization.
BUG=None TEST=emerge-kukui coreboot; boots properly
Change-Id: If844da84ecca31307127b14c66bbe17c408699f3 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 4 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/34853/1
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index db00ed4..bd6760e 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -108,8 +108,9 @@ const char *name = panel->edid.ascii_string; if (!*name) name = "unknown name"; - printk(BIOS_INFO, "%s: Found ID %d: '%s' %s\n", __func__, - panel_id, name, mode_name ? mode_name : "(unknown mode)"); + printk(BIOS_INFO, "%s: Found ID %d: '%s %s' %s\n", __func__, + panel_id, panel->edid.manufacturer_name, name, + mode_name ? mode_name : "(unknown mode)"); return panel; }
diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c index 15e46a4..8f7ef2b 100644 --- a/src/mainboard/google/kukui/panel_kodama.c +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -18,6 +18,7 @@ static struct panel_description BOE_TV101WUM_N53 = { .edid = { .ascii_string = "TV101WUM-N53", + .manufacturer_name = "BOE", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index ad06f39..0562820 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -18,6 +18,7 @@ static struct panel_description AUO_KD101N80_45NA = { .edid = { .ascii_string = "KD101N80-45NA", + .manufacturer_name = "AUO", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { @@ -45,6 +46,7 @@ static struct panel_description BOE_TV101WUM_NL6 = { .edid = { .ascii_string = "TV101WUM-NL6", + .manufacturer_name = "BOE", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c index eb2f228..a154185 100644 --- a/src/mainboard/google/kukui/panel_kukui.c +++ b/src/mainboard/google/kukui/panel_kukui.c @@ -39,7 +39,8 @@ static struct panel_description P097PFG_SSD2858 = { .power_on = power_on_ssd2858, .edid = { - .ascii_string = "CMN P097PFG", + .ascii_string = "P097PFG", + .manufacturer_name = "CMN", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = {
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34853 )
Change subject: mb/google/kukui: Report panel manufacturer name ......................................................................
Patch Set 1: Code-Review+2
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34853
to look at the new patch set (#5).
Change subject: mb/google/kukui: Report panel manufacturer name ......................................................................
mb/google/kukui: Report panel manufacturer name
The src/lib/edid now supports reporting manufacturer name so we should define that in MIPI panels and print out in initialization.
BUG=None TEST=emerge-kukui coreboot; boots properly
Change-Id: If844da84ecca31307127b14c66bbe17c408699f3 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 4 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/34853/5
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34853 )
Change subject: mb/google/kukui: Report panel manufacturer name ......................................................................
mb/google/kukui: Report panel manufacturer name
The src/lib/edid now supports reporting manufacturer name so we should define that in MIPI panels and print out in initialization.
BUG=None TEST=emerge-kukui coreboot; boots properly
Change-Id: If844da84ecca31307127b14c66bbe17c408699f3 Signed-off-by: Hung-Te Lin hungte@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 4 files changed, 8 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 7bf2580..9f90b0f 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -108,8 +108,9 @@ const char *name = panel->edid.ascii_string; if (name[0] == '\0') name = "unknown name"; - printk(BIOS_INFO, "%s: Found ID %d: '%s' %s\n", __func__, - panel_id, name, mode_name ? mode_name : "(unknown mode)"); + printk(BIOS_INFO, "%s: Found ID %d: '%s %s' %s\n", __func__, + panel_id, panel->edid.manufacturer_name, name, + mode_name ? mode_name : "(unknown mode)"); return panel; }
diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c index 15e46a4..8f7ef2b 100644 --- a/src/mainboard/google/kukui/panel_kodama.c +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -18,6 +18,7 @@ static struct panel_description BOE_TV101WUM_N53 = { .edid = { .ascii_string = "TV101WUM-N53", + .manufacturer_name = "BOE", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index ad06f39..0562820 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -18,6 +18,7 @@ static struct panel_description AUO_KD101N80_45NA = { .edid = { .ascii_string = "KD101N80-45NA", + .manufacturer_name = "AUO", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { @@ -45,6 +46,7 @@ static struct panel_description BOE_TV101WUM_NL6 = { .edid = { .ascii_string = "TV101WUM-NL6", + .manufacturer_name = "BOE", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c index eb2f228..a154185 100644 --- a/src/mainboard/google/kukui/panel_kukui.c +++ b/src/mainboard/google/kukui/panel_kukui.c @@ -39,7 +39,8 @@ static struct panel_description P097PFG_SSD2858 = { .power_on = power_on_ssd2858, .edid = { - .ascii_string = "CMN P097PFG", + .ascii_string = "P097PFG", + .manufacturer_name = "CMN", .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = {
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)