Attention is currently required from: David Wu, Evan Green, Tim Wawrzynczak, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55249 )
Change subject: mb/google/dedede/var/metaknight: Turn off lte power when s0ix ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55249/comment/d7b0af1c_45a525a3 PS6, Line 9: Turn off lte power when s0ix for power saving. Please mention that this is done using ACPI.
https://review.coreboot.org/c/coreboot/+/55249/comment/7040354e_152664b2 PS6, Line 12: TEST= measure lte power comsumption is 0mV under s0ix How much was it before?
File src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl:
https://review.coreboot.org/c/coreboot/+/55249/comment/046909b1_e0d0b638 PS6, Line 3: LTE_EN What does EN mean?
https://review.coreboot.org/c/coreboot/+/55249/comment/bbd97acc_db141ba5 PS6, Line 5: enter entering
https://review.coreboot.org/c/coreboot/+/55249/comment/665f35ad_7335a667 PS6, Line 8: If (Arg0) { Is there a way to check in ACPI/ASL, if the device is present?