Change in ...coreboot[master]: soc/intel/icelake: Remove unnecessary USB charging ASL entries

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31117

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

soc/intel/icelake: Remove unnecessary USB charging ASL entries

This patch removes stale ASL entries added in past due to chromeos
requirement.

BUG=115755982

Change-Id: I18b57822ce3198fb96aae977f0b552ff2d4a14ee
---
M src/soc/intel/icelake/acpi/globalnvs.asl
1 file changed, 0 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/31117/1

diff --git a/src/soc/intel/icelake/acpi/globalnvs.asl b/src/soc/intel/icelake/acpi/globalnvs.asl
index b8f4d2f..678ce5a 100644
--- a/src/soc/intel/icelake/acpi/globalnvs.asl
+++ b/src/soc/intel/icelake/acpi/globalnvs.asl
@@ -48,34 +48,8 @@
    U2WE,	16,	// 0x2b - 0x2c USB2 Wake Enable Bitmap
    U3WE,	16,	// 0x2d - 0x2e USB3 Wake Enable Bitmap
    UIOR,	8,	// 0x2f - UART debug controller init on S3 resume
-	S5U0,	8,	// 0x30 - Enable USB in S5
-	S3U0,	8,	// 0x31 - Enable USB in S3

/* ChromeOS specific */
    Offset (0x100),
    #include <vendorcode/google/chromeos/acpi/gnvs.asl>
 }
-
-/* Set flag to enable USB charging in S3 */
-Method (S3UE)
-{
-	Store (One, \S3U0)
-}
-
-/* Set flag to disable USB charging in S3 */
-Method (S3UD)
-{
-	Store (Zero, \S3U0)
-}
-
-/* Set flag to enable USB charging in S5 */
-Method (S5UE)
-{
-	Store (One, \S5U0)
-}
-
-/* Set flag to disable USB charging in S5 */
-Method (S5UD)
-{
-	Store (Zero, \S5U0)
-}

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31117/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31117/1//COMMIT_MSG@15 
PS1, Line 15: 
Signed-off-by line is missing.

[Subrata Banik (Code Review)]

Hello Aaron Durbin, Patrick Rudolph, Rajat Jain, Aamir Bohra, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31117

to look at the new patch set (#2).

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

soc/intel/icelake: Remove unnecessary USB charging ASL entries

This patch removes stale ASL entries added in past due to chromeos
requirement.

BUG=115755982

Change-Id: I18b57822ce3198fb96aae977f0b552ff2d4a14ee
Signed-off-by: Subrata Banik 
---
M src/soc/intel/icelake/acpi/globalnvs.asl
1 file changed, 0 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/31117/2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31117/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31117/1//COMMIT_MSG@15 
PS1, Line 15:
> Signed-off-by line is missing.

added.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 2: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/31117/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31117/2//COMMIT_MSG@9 
PS2, Line 9: chromeos
           : requirement
And the requirement is not valid anymore?

https://review.coreboot.org/#/c/31117/2//COMMIT_MSG@11 
PS2, Line 11: 
Tested how?

[Subrata Banik (Code Review)]

Hello Patrick Rudolph, Aaron Durbin, Rajat Jain, Aamir Bohra, Paul Menzel, Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31117

to look at the new patch set (#3).

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

soc/intel/icelake: Remove unnecessary USB charging ASL entries

This patch removes stale ASL entries added in past due to chromeos
requirement.

BUG=115755982
TEST=Build and boot ICL platform without any problem.

Change-Id: I18b57822ce3198fb96aae977f0b552ff2d4a14ee
Signed-off-by: Subrata Banik 
---
M src/soc/intel/icelake/acpi/globalnvs.asl
1 file changed, 0 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/31117/3

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31117/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31117/2//COMMIT_MSG@9 
PS2, Line 9: chromeos
           : requirement
> And the requirement is not valid anymore?

yes, i have that partner bug for more details.

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 3: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

Patch Set 3: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31117 )

Change subject: soc/intel/icelake: Remove unnecessary USB charging ASL entries
......................................................................

soc/intel/icelake: Remove unnecessary USB charging ASL entries

This patch removes stale ASL entries added in past due to chromeos
requirement.

BUG=115755982
TEST=Build and boot ICL platform without any problem.

Change-Id: I18b57822ce3198fb96aae977f0b552ff2d4a14ee
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/31117
Reviewed-by: Duncan Laurie 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Patrick Rudolph 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/icelake/acpi/globalnvs.asl
1 file changed, 0 insertions(+), 26 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Patrick Rudolph: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/icelake/acpi/globalnvs.asl b/src/soc/intel/icelake/acpi/globalnvs.asl
index b8f4d2f..678ce5a 100644
--- a/src/soc/intel/icelake/acpi/globalnvs.asl
+++ b/src/soc/intel/icelake/acpi/globalnvs.asl
@@ -48,34 +48,8 @@
    U2WE,	16,	// 0x2b - 0x2c USB2 Wake Enable Bitmap
    U3WE,	16,	// 0x2d - 0x2e USB3 Wake Enable Bitmap
    UIOR,	8,	// 0x2f - UART debug controller init on S3 resume
-	S5U0,	8,	// 0x30 - Enable USB in S5
-	S3U0,	8,	// 0x31 - Enable USB in S3

/* ChromeOS specific */
    Offset (0x100),
    #include <vendorcode/google/chromeos/acpi/gnvs.asl>
 }
-
-/* Set flag to enable USB charging in S3 */
-Method (S3UE)
-{
-	Store (One, \S3U0)
-}
-
-/* Set flag to disable USB charging in S3 */
-Method (S3UD)
-{
-	Store (Zero, \S3U0)
-}
-
-/* Set flag to enable USB charging in S5 */
-Method (S5UE)
-{
-	Store (One, \S5U0)
-}
-
-/* Set flag to disable USB charging in S5 */
-Method (S5UD)
-{
-	Store (Zero, \S5U0)
-}