Change in coreboot[master]: acpi/acpigen.h: Add more intuitive AML package closing functions - coreboot-gerrit

19 Feb 2021


      Attention is currently required from: Angel Pons, Jan Dabros, Duncan Laurie.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50910 )
Change subject: acpi/acpigen.h: Add more intuitive AML package closing functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Personally, I like to use C scopes to know what gets closed with a particular acpigen_pop_len() call […]
Oh, I see. C scopes are very helpful.
Regarding my patch, I *think* that acpigen_pop_len() is not very explicit in what is does, without diving into details of implementation. My aim was to make acpigen API easier to understand for new developers.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd
Gerrit-Change-Number: 50910
Gerrit-PatchSet: 1
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Duncan Laurie dlaurie@gmail.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Attention: Duncan Laurie dlaurie@gmail.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 15:49:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment