Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf T...

[Chris Zhou (Code Review)]

Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31062

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen

Current Melfas touchscreen driver cannot unregister ifself when
connecting without Melfas touchscreen or connecting with other devices.
And Melfas touchscreen FW can use I2C and HID over I2C driver, so
switch to using HID over I2C driver.

BUG=b:122710830
BRANCH=master
TEST=Verify touchscreen on sarien works with this change.

Signed-off-by: Chris Zhou 
Change-Id: If04a2904a0f72a6c8363ab2c9865926c71cb5186
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 10 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31062/1

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 59f1f30..05c63bd 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -221,14 +221,16 @@
    	end
    	device pci 14.5 off end # SDCard
    	device pci 15.0 on
-			chip drivers/i2c/generic
-				register "hid" = ""MLFS0000""
-				register "desc" = ""Melfas Touchscreen""
-				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
-				register "probed" = "1"
-				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
-				register "enable_delay_ms" = "5"
-				register "has_power_resource" = "1"
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ACPI0C50""
+				register "generic.desc" = ""Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
+				register "generic.enable_delay_ms" = "5"
+				register "generic.enable_off_delay_ms" = "100"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x0"
    			device i2c 10 on end
    		end
    	end # I2C #0

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants... 
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:

https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants... 
PS1, Line 229: register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
More than 80?

[Chris Zhou (Code Review)]

Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31062

to look at the new patch set (#2).

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen

Current Melfas touchscreen driver cannot unregister ifself when
connecting without Melfas touchscreen or connecting with other devices.
And Melfas touchscreen FW can use I2C and HID over I2C driver, so
switch to using HID over I2C driver.

BUG=b:122710830
BRANCH=master
TEST=Verify touchscreen on sarien works with this change.

Signed-off-by: Chris Zhou 
Change-Id: If04a2904a0f72a6c8363ab2c9865926c71cb5186
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 11 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31062/2

[Chris Zhou (Code Review)]

Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants... 
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:

https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants... 
PS1, Line 229: register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
> More than 80?

Done

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

Patch Set 2: Code-Review+2

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31062/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31062/2//COMMIT_MSG@7 
PS2, Line 7: mb/google/sarien/variants/sarien
Just mb/google/sarien is good enough.

Change in ...coreboot[master]: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen

[EricR Lai (Code Review)]

EricR Lai has uploaded a new patch set (#3) to the change originally created by Chris Zhou. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

mb/google/sarien: Using HID over I2C to enable Melf TouchScreen

Current Melfas touchscreen driver cannot unregister ifself when
connecting without Melfas touchscreen or connecting with other devices.
And Melfas touchscreen FW can use I2C and HID over I2C driver, so
switch to using HID over I2C driver.

BUG=b:122710830
BRANCH=master
TEST=Verify touchscreen on sarien works with this change.

Signed-off-by: Chris Zhou 
Change-Id: If04a2904a0f72a6c8363ab2c9865926c71cb5186
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 11 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31062/3

Change in ...coreboot[master]: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

Patch Set 3:
> Patch Set 2:
>
> (1 comment)

done

Change in ...coreboot[master]: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31062 )

Change subject: mb/google/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................

mb/google/sarien: Using HID over I2C to enable Melf TouchScreen

Current Melfas touchscreen driver cannot unregister ifself when
connecting without Melfas touchscreen or connecting with other devices.
And Melfas touchscreen FW can use I2C and HID over I2C driver, so
switch to using HID over I2C driver.

BUG=b:122710830
BRANCH=master
TEST=Verify touchscreen on sarien works with this change.

Signed-off-by: Chris Zhou 
Change-Id: If04a2904a0f72a6c8363ab2c9865926c71cb5186
Reviewed-on: https://review.coreboot.org/c/31062
Tested-by: build bot (Jenkins) 
Reviewed-by: Lijian Zhao 
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 11 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lijian Zhao: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 76e5db7..0bf7e98 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -221,14 +221,17 @@
    	end
    	device pci 14.5 off end # SDCard
    	device pci 15.0 on
-			chip drivers/i2c/generic
-				register "hid" = ""MLFS0000""
-				register "desc" = ""Melfas Touchscreen""
-				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
-				register "probed" = "1"
-				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
-				register "enable_delay_ms" = "5"
-				register "has_power_resource" = "1"
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ACPI0C50""
+				register "generic.desc" = ""Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.enable_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
+				register "generic.enable_delay_ms" = "5"
+				register "generic.enable_off_delay_ms" = "100"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x0"
    			device i2c 10 on end
    		end
    	end # I2C #0