Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: mb/google/octopus: Add API to disable USB devices from devicetree ......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/33377/1/src/mainboard/google/octopus/mainboa... File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33377/1/src/mainboard/google/octopus/mainboa... PS1, Line 191: usb_device_disable Prefer two improvements: 1) move inside src/soc/intel/common/block/xhci.c 2) Check Current Connect Status(CCS) bit in the USB Port Status and Control register in the XHCI register block and then disable the unconnected devices. I believe it works for externally visible ports too.