Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84545?usp=email )
Change subject: mb/google/brox/jubilant: Modify FP IRQ pin on disable pads
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84545/comment/7eecc5a4_7f4f2e87?usp... :
PS4, Line 8:
: In previous cl:84124
Previously in CB:84124
fixed.
https://review.coreboot.org/c/coreboot/+/84545/comment/066dd6fc_3ecaa5a1?usp... :
PS4, Line 10: , and fp_disable_pads need to be updated.
. Hence update fp_disable_pads configuration to include that GPIO.
fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84545?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee4c3d3f000f884ca8a77ae8c72ccbeebfeb865f
Gerrit-Change-Number: 84545
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Oct 2024 02:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com