Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/i... File src/cpu/amd/family_10h-family_15h/init_cpus.c:
https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/i... PS15, Line 1062: !!
It transforms nvram (any integer value, where 0 is meant to be false, and everything else is true) i […]
Yup, I've done this before. I would remove it then.
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage... File src/soc/intel/fsp_baytrail/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage... PS15, Line 253: cbmem_was_initted
You are right, but that will be some "crowded" […]
Makes sense to not clutter this one, but for the other two cbmem_was_initted cases, the function call is roughly as long as the variable.
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/roms... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/roms... PS15, Line 119: cbmem_was_initted
Oops, it shoild be '!cbmem_was_initted'
And this one too.
https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/... File src/southbridge/intel/fsp_rangeley/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/... PS15, Line 122: cbmem_was_initted
sould be "!cbmem_was_initted"
In this one, I think replacing cbmem_was_initted with the function call is not going to clutter the code.
-
Angel Pons (Code Review)