build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28592 )
Change subject: soc/sifive/fu540: create ram_resource with actual memory size ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c File src/soc/sifive/fu540/soc.c:
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@18 PS1, Line 18: ram_resource(dev, 0, (uintptr_t)_dram/KiB, code indent should use tabs where possible
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@18 PS1, Line 18: ram_resource(dev, 0, (uintptr_t)_dram/KiB, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@19 PS1, Line 19: (sdram_max_addressable_mb() - fb_size)*KiB - code indent should use tabs where possible
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@19 PS1, Line 19: (sdram_max_addressable_mb() - fb_size)*KiB - please, no spaces at the start of a line
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@20 PS1, Line 20: (uintptr_t)_dram/KiB); code indent should use tabs where possible
https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@20 PS1, Line 20: (uintptr_t)_dram/KiB); please, no spaces at the start of a line