[S] Change in coreboot[main]: mb/prodrive/atlas: Remove the workaround for CLKREQ pins - coreboot-gerrit

14 Nov 2023


      Attention is currently required from: Angel Pons, Christian Walter, Lean Sheng Tan.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79021?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/prodrive/atlas: Remove the workaround for CLKREQ pins
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/prodrive/atlas/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/79021/comment/217dc124_dc5041a6 :
PS3, Line 75: 	mcfg->CpuPcieRpClockReqMsgEnable[2] = 0;
can you test if the ones for CPU are also still needed? wouldn't be surprised if they now magically worked too.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79021?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbab617428551accda66499b7c2a32b2fa8c1689
Gerrit-Change-Number: 79021
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 14 Nov 2023 21:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment