Change in coreboot[master]: console: Correct printing of hexadecimal integers

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

console: Correct printing of hexadecimal integers

Commit b19946cc62 (console: Remove support for printing extra bases)
truncated the digits string to only print integers of up to base 16.
However, that string was also used to print the leading 'x' or 'X' for
hexadecimal integers and is now too short. Fix this to prevent an out
of bounds read.

Change-Id: Iab6470cc88f445f074cf7c0b675346b37f3f2375
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402999
---
M src/console/vtxprintf.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/34211/1

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c
index b50f398..848ad50 100644
--- a/src/console/vtxprintf.c
+++ b/src/console/vtxprintf.c
@@ -107,7 +107,10 @@
    		call_tx('0'), count++;
    	else if (base == 16) {
    		call_tx('0'), count++;
-			call_tx(digits[33]), count++;
+			if (type & LARGE)
+				call_tx('X'), count++;
+			else
+				call_tx('x'), count++;
    	}
    }
    if (!(type & LEFT)) {

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

Patch Set 1:

This slipped by when I was doing the previous commit and should probably be merged rather quickly

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

Patch Set 1: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

Patch Set 1: Code-Review+1

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

Patch Set 1: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

Patch Set 1: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

console: Correct printing of hexadecimal integers

Commit b19946cc62 (console: Remove support for printing extra bases)
truncated the digits string to only print integers of up to base 16.
However, that string was also used to print the leading 'x' or 'X' for
hexadecimal integers and is now too short. Fix this to prevent an out
of bounds read.

Change-Id: Iab6470cc88f445f074cf7c0b675346b37f3f2375
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402999
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34211
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Nico Huber 
Reviewed-by: Julius Werner 
---
M src/console/vtxprintf.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Nico Huber: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, but someone else must approve
  Julius Werner: Looks good to me, approved

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c
index b50f398..848ad50 100644
--- a/src/console/vtxprintf.c
+++ b/src/console/vtxprintf.c
@@ -107,7 +107,10 @@
    		call_tx('0'), count++;
    	else if (base == 16) {
    		call_tx('0'), count++;
-			call_tx(digits[33]), count++;
+			if (type & LARGE)
+				call_tx('X'), count++;
+			else
+				call_tx('x'), count++;
    	}
    }
    if (!(type & LEFT)) {