Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 82:
(9 comments)
Now that this was merged, marked a few things that were not actually resolved yet, for ease of tracking.
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... PS74, Line 30: S5 resume
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/Documentation/mainboard/su... PS74, Line 37: 10GB
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 67: : config SUBSYSTEM_VENDOR_ID : hex : default 0x8086
Done
I see... Then, it should match the subsystem ID on the devicetree.
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 1: BOARD_SUPERMICRO_X11SSH_PLUS_TF : bool "X11SSH+-TF"
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/bootblock.c:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 37: garbeled
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 203: device domain 0 on
We will do it in a follow-up.
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 208: JPCIE1
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 216: JPCIE1
Done
Not done
https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... PS74, Line 219: device pci 00.0 on end # Aspeed 2400 VGA
Done
still curious about it
-
Angel Pons (Code Review)