Attention is currently required from: Bora Guvendik, Selma Bensaid, Rizwan Qureshi, Krishna P Bhat D, Usha P, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61162 )
Change subject: soc/intel/common: Re-use Alder Lake-M device IDs for Alder Lake-N
......................................................................
Patch Set 3:
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/61162/comment/00540461_8376891e
PS3, Line 3400: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP1 0x54b8
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP2 0x54b9
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP3 0x54ba
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP4 0x54bb
: #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP5 0x54bc
: #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP6 0x54bd
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP7 0x54be
: #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP8 0x54bf
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP9 0x54b0
: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP10 0x54b1
Hm, for ADL-N, though, wouldn't these be called
RP1 - RP7 ? instead of 1, 2, 3, 4, 7, 9, 10?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61162
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6042017c6189cbc3ca9dce0e50acfb68ea4003f1
Gerrit-Change-Number: 61162
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment