Change in coreboot[master]: mb/ocp/tiogapass/acpi: Move uncore from \_SB scope

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Move uncore from _SB scope
......................................................................

mb/ocp/tiogapass/acpi: Move uncore from _SB scope

Change-Id: I98a8d60b585e2eafd76948baea0f249a029bae09
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/dsdt.asl
1 file changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45766/1

diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl
index bd31251..78475e0 100644
--- a/src/mainboard/ocp/tiogapass/dsdt.asl
+++ b/src/mainboard/ocp/tiogapass/dsdt.asl
@@ -18,9 +18,5 @@
    #include <soc/intel/xeon_sp/skx/acpi/globalnvs.asl>

#include <cpu/intel/common/acpi/cpu.asl>
-
-	// Xeon-SP ACPI tables
-	Scope (_SB) {
-		#include <soc/intel/xeon_sp/skx/acpi/uncore.asl>
-	}
+	#include <soc/intel/xeon_sp/skx/acpi/uncore.asl>
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Move uncore from _SB scope
......................................................................

Patch Set 1: Code-Review+1

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Move uncore from _SB scope
......................................................................

Patch Set 1:

This would be +2 if it had some sort of detail for the change. Something like "Simplify the mainboard dsdt.asl. _SB scope is set in uncore.asl and not needed here."

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Jonathan Zhang, Jay Talbott, Paul Menzel, Jingle Hsu, Angel Pons, Andrey Petrov, Patrick Rudolph, Lance Zhao, Marc Jones, Anjaneya "Reddy" Chagam, Nico Huber, Johnny Lin, David Hendricks, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45766

to look at the new patch set (#2).

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

The corresponding devices and objects are already included in the
System Bus ACPI scope inside uncore.asl. There is no need to do this
again in the DSDT of the motherboard.

Change-Id: I98a8d60b585e2eafd76948baea0f249a029bae09
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/dsdt.asl
1 file changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45766/2

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 2:
> Patch Set 1:
>
> This would be +2 if it had some sort of detail for the change. Something like "Simplify the mainboard dsdt.asl. _SB scope is set in uncore.asl and not needed here."

Ok. I made some changes in the commit message. Please review

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 2: Code-Review+1
> Patch Set 2:
> > Patch Set 1:
> >
> > This would be +2 if it had some sort of detail for the change. Something like "Simplify the mainboard dsdt.asl. _SB scope is set in uncore.asl and not needed here."
>
> Ok. I made some changes in the commit message. Please review

I'm going to +1 because CB:45269 fixes related things

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 2: Code-Review+2

Needs a rebase, though

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Jonathan Zhang, Jay Talbott, Paul Menzel, Jingle Hsu, Angel Pons, Andrey Petrov, Patrick Rudolph, Lance Zhao, Marc Jones, Anjaneya "Reddy" Chagam, Nico Huber, Johnny Lin, David Hendricks, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45766

to look at the new patch set (#3).

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

The corresponding devices and objects are already included in the
System Bus ACPI scope inside uncore.asl. There is no need to do this
again in the DSDT of the motherboard.

Change-Id: I98a8d60b585e2eafd76948baea0f249a029bae09
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/dsdt.asl
1 file changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45766/3

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

The corresponding devices and objects are already included in the
System Bus ACPI scope inside uncore.asl. There is no need to do this
again in the DSDT of the motherboard.

Change-Id: I98a8d60b585e2eafd76948baea0f249a029bae09
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45766
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/ocp/tiogapass/dsdt.asl
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl
index 4aff668..d5b7b42 100644
--- a/src/mainboard/ocp/tiogapass/dsdt.asl
+++ b/src/mainboard/ocp/tiogapass/dsdt.asl
@@ -18,9 +18,5 @@
    #include <soc/intel/xeon_sp/acpi/globalnvs.asl>

#include <cpu/intel/common/acpi/cpu.asl>
-
-	// Xeon-SP ACPI tables
-	Scope (_SB) {
-		#include <soc/intel/xeon_sp/acpi/uncore.asl>
-	}
+	#include <soc/intel/xeon_sp/acpi/uncore.asl>
 }

Change in coreboot[master]: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45766 )

Change subject: mb/ocp/tiogapass/acpi: Exclude uncore.asl from _SB scope
......................................................................

Patch Set 4: Code-Review+1