Change in coreboot[master]: soc/amd/common/psp: expand fam17h to family 17h in Kconfig help text
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47275 )
Change subject: soc/amd/common/psp: expand fam17h to family 17h in Kconfig help text ......................................................................
soc/amd/common/psp: expand fam17h to family 17h in Kconfig help text
This should make the help text slightly more readable.
Change-Id: I9284c9c638e1d217d4605523dde004781f4343f9 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/psp/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/47275/1
diff --git a/src/soc/amd/common/block/psp/Kconfig b/src/soc/amd/common/block/psp/Kconfig index bf0477b..749ad8a 100644 --- a/src/soc/amd/common/block/psp/Kconfig +++ b/src/soc/amd/common/block/psp/Kconfig @@ -11,14 +11,14 @@ default n select SOC_AMD_COMMON_BLOCK_PSP help - Used by the PSP in AMD systems before fam17h, e.g. stoneyridge. + Used by the PSP in AMD systems before family 17h, e.g. stoneyridge.
config SOC_AMD_COMMON_BLOCK_PSP_GEN2 bool default n select SOC_AMD_COMMON_BLOCK_PSP help - Used by the PSP in AMD fam17h CPUs and possibly newer ones. + Used by the PSP in AMD family 17h CPUs and possibly newer ones.
config SOC_AMD_PSP_SELECTABLE_SMU_FW bool
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47275 )
Change subject: soc/amd/common/psp: expand fam17h to family 17h in Kconfig help text ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47275/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/47275/1/src/soc/amd/common/block/ps... PS1, Line 21: possibly What do you think about removing this? We know 19h is similar to 17h.
Hello build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47275
to look at the new patch set (#2).
Change subject: soc/amd/common/psp: expand CPU family names in Kconfig help text ......................................................................
soc/amd/common/psp: expand CPU family names in Kconfig help text
Expand fam17h to family 17h to make the help text slightly easier to understand and add family 19h to the description of SOC_AMD_COMMON_BLOCK_PSP_GEN2.
Change-Id: I9284c9c638e1d217d4605523dde004781f4343f9 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/psp/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/47275/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47275 )
Change subject: soc/amd/common/psp: expand CPU family names in Kconfig help text ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47275/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/47275/1/src/soc/amd/common/block/ps... PS1, Line 21: possibly
What do you think about removing this? We know 19h is similar to 17h.
i added family 19h, but basically kept the possibly newer ones
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47275 )
Change subject: soc/amd/common/psp: expand CPU family names in Kconfig help text ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47275 )
Change subject: soc/amd/common/psp: expand CPU family names in Kconfig help text ......................................................................
soc/amd/common/psp: expand CPU family names in Kconfig help text
Expand fam17h to family 17h to make the help text slightly easier to understand and add family 19h to the description of SOC_AMD_COMMON_BLOCK_PSP_GEN2.
Change-Id: I9284c9c638e1d217d4605523dde004781f4343f9 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47275 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/psp/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/psp/Kconfig b/src/soc/amd/common/block/psp/Kconfig index bf0477b..85ec987 100644 --- a/src/soc/amd/common/block/psp/Kconfig +++ b/src/soc/amd/common/block/psp/Kconfig @@ -11,14 +11,14 @@ default n select SOC_AMD_COMMON_BLOCK_PSP help - Used by the PSP in AMD systems before fam17h, e.g. stoneyridge. + Used by the PSP in AMD systems before family 17h, e.g. stoneyridge.
config SOC_AMD_COMMON_BLOCK_PSP_GEN2 bool default n select SOC_AMD_COMMON_BLOCK_PSP help - Used by the PSP in AMD fam17h CPUs and possibly newer ones. + Used by the PSP in AMD family 17h, 19h and possibly newer CPUs.
config SOC_AMD_PSP_SELECTABLE_SMU_FW bool
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)