Change in coreboot[master]: libpayload: cbmem_console: Drop loglevel markers from snapshot

[Raul Rangel (Code Review)]

Attention is currently required from: Julius Werner, Yu-Ping Wu.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )

Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot
......................................................................

Patch Set 1: Code-Review+2

(4 comments)

Patchset:

PS1: 
I'm fine landing this as is and adding callback functionality later if necessary.

File payloads/libpayload/drivers/cbmem_console.c:

https://review.coreboot.org/c/coreboot/+/62506/comment/cfdd5984_0303961a 
PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few
             : 	   unprintable characters like '\0'. Replace them with '?' on output. */
             : 	for (cursor = 0; cursor < size; cursor++)
             : 		if (!isprint(console_c[cursor]) && !isspace(console_c[cursor]))
             : 			console_c[cursor] = '?';
> Maybe we should just keep the non-printable characters, and let payloads decide how to deal with the […]

Are you suggesting a callback?

https://review.coreboot.org/c/coreboot/+/62506/comment/f190b539_730ec93c 
PS1, Line 85: Due to stupid
            : 	   licensing restrictions
Why can you add a BSD version in libpayload? You are the copyright holder. Or maybe extract it into a dual licenced file?

https://review.coreboot.org/c/coreboot/+/62506/comment/f96eeb5b_7f279d48 
PS1, Line 90: memory corruption may occur between reboots
Side note: I just learned that the kernel ramoops has an ECC function to correct errors like this. It might be interesting to add such functionality down the line.