Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
dedede: modify magolor config to SPI ROM size 16MB
modify magolor config to SPI ROM size 16MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/1
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index bfcc427..40738a0 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -59,4 +59,3 @@ bool "-> Magolor" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP - select BOARD_ROMSIZE_KB_32768
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44204
to look at the new patch set (#2).
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
dedede: modify magolor config to SPI ROM size 16MB
modify magolor config to SPI ROM size 16MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quantatw.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/2
Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44204
to look at the new patch set (#3).
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
dedede: modify magolor config to SPI ROM size 16MB
modify magolor config to SPI ROM size 16MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/3
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
Patch Set 3: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@7 PS3, Line 7: dedede: modify magolor config to SPI ROM size 16MB Nit: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: dedede: modify magolor config to SPI ROM size 16MB ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@9 PS3, Line 9: modify magolor config to SPI ROM size 16MB 1. Maybe: Decrease the SPI ROM size from 32 MB to 16 MB 2. Why, was the board design changed?
Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44204
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM ......................................................................
mb/google/dedede/var/magalor: Select 16 MB SPI ROM
modify magolor config to SPI ROM size 16MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/4
Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44204
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM ......................................................................
mb/google/dedede/var/magalor: Select 16 MB SPI ROM
Decrease the SPI ROM size from 32 MB to 16 MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/5
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@7 PS3, Line 7: dedede: modify magolor config to SPI ROM size 16MB
Nit: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
OK
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@9 PS3, Line 9: modify magolor config to SPI ROM size 16MB
- Maybe: Decrease the SPI ROM size from 32 MB to 16 MB […]
OK. the board design changed is for cost down
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG@7 PS5, Line 7: magalor nit: mag*o*lor
Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Angel Pons, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44204
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM ......................................................................
mb/google/dedede/var/magolor: Select 16 MB SPI ROM
Decrease the SPI ROM size from 32 MB to 16 MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/6
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG@7 PS5, Line 7: magalor
nit: mag*o*lor
ok
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44204 )
Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM ......................................................................
mb/google/dedede/var/magolor: Select 16 MB SPI ROM
Decrease the SPI ROM size from 32 MB to 16 MB
BUG=b:58540772 BRANCH=None TEST= build firmware and check the magolor bin size
Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44204 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Henry Sun henrysun@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Ren Kuo: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index bfcc427..40738a0 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -59,4 +59,3 @@ bool "-> Magolor" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP - select BOARD_ROMSIZE_KB_32768
-
Angel Pons (Code Review) -
Henry Sun (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Ren Kuo (Code Review)