Attention is currently required from: Felix Singer, Hung-Te Lin, Nico Huber, Yidi Lin, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email )
Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/asurada/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/d6309850_ae0f0d88 : PS1, Line 11: config BOARD_SPECIFIC_OPTIONS
So this is something I believe others tried to get rid off too, […]
That's a separate discussion we can have if you want, but personally I think things are ordered better in this version. While Kconfig doesn't care if an option is referenced before it is defined (right?), I think things are easier to read if they logically progress from top to bottom. The effect is not so clear in this file, but if you look at https://review.coreboot.org/c/coreboot/+/79022/1/src/mainboard/google/gru/Kc... for example, with the version you suggest we'd have a `BOARD_GOOGLE_GRU_COMMON` at the top that has a long list of `select`s, including a bunch that depend on `if GRU_HAS_TPM2`, and then the definition for what `GRU_HAS_TPM2` means would only come below that.
I know some of the Intel boards do things differently, but many of their Kconfig files also have a ton of unnecessary duplication, so I don't think they're necessarily a good model to follow.