Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node
a. USI_REPORT_EN is no longer set to high in coreboot. Instead GPIO_144 is exposed as stop_gpio in ACPI to allow OS to control this pad as required. b. Add Delay after stop_gpio Low - 300ms
BUG=b:162263398
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I3d4dcb6e5cae5d9515abfd415315ec4114ca80b4 --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/44107/1
diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb index a4cdac6..1f97d1c 100644 --- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb +++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb @@ -79,6 +79,8 @@ register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" register "generic.reset_delay_ms" = "20" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" + register "generic.stop_delay_ms" = "300" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: register "generic.stop_delay_ms" = "300" Shouldn't we have 'register generic.disable_gpio_export_in_crs = 1' here?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: register "generic.stop_delay_ms" = "300"
Shouldn't we have 'register generic. […]
Yes, we need generic.disable_gpio_export_in_crs as well.
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: 300 Does this delay of 300ms match the spec?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: 300
Does this delay of 300ms match the spec?
I see from the bug that the 300ms is the recommended delay. Just a note that this 300ms would result in adding delay to both boot and resume paths. Some other projects have been able to reduce this delay to 100ms (IIRC). So, it would be good to see if that is an option here.
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: register "generic.stop_delay_ms" = "300"
Yes, we need generic.disable_gpio_export_in_crs as well.
Done, Thank you!
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: 300
I see from the bug that the 300ms is the recommended delay. […]
Because EN_PWR_TOUCHSCREEN will be changed in schematic V3.61. We will re-measuring and test timing then modify this value on Ezkinil next build.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: 300
Because EN_PWR_TOUCHSCREEN will be changed in schematic V3.61. […]
SG. Thanks! Did you miss pushing an updated patchset?
David Wu has uploaded a new patch set (#2) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node
a. USI_REPORT_EN is no longer set to high in coreboot. Instead GPIO_144 is exposed as stop_gpio in ACPI to allow OS to control this pad as required. b. Add Delay after stop_gpio Low - 300ms
BUG=b:162263398
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I3d4dcb6e5cae5d9515abfd415315ec4114ca80b4 --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/44107/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v... PS1, Line 83: 300
SG. […]
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node ......................................................................
mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node
a. USI_REPORT_EN is no longer set to high in coreboot. Instead GPIO_144 is exposed as stop_gpio in ACPI to allow OS to control this pad as required. b. Add Delay after stop_gpio Low - 300ms
BUG=b:162263398
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I3d4dcb6e5cae5d9515abfd415315ec4114ca80b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44107 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/ezkinil/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb index b06f4bc..1808a0f 100644 --- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb +++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb @@ -88,7 +88,10 @@ register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" register "generic.reset_delay_ms" = "20" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" + register "generic.stop_delay_ms" = "300" register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end