Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules ......................................................................
util/abuild/abuild: Do not check out submodules
This force-downloads the qc_blobs repository, whose license is then automatically accepted. This may also cause race conditions with git.
Change-Id: Id760172289abbe4d5ad5f230c9f1d3e1ab3908ec Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/abuild/abuild 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45607/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index 7561495..2ba2f72 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -794,8 +794,6 @@ echo | xargs -P ${cpus:-0} -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1 fi
-git submodule update --checkout --init - if [ "$USE_XARGS" = "0" ]; then test "$MAKEFLAGS" == "" && test "$cpus" != "" && export MAKEFLAGS="-j $cpus" export MAKEFLAGS="$MAKEFLAGS UPDATED_SUBMODULES=1" # no need to re-download
Patrick Georgi has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules ......................................................................
Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules ......................................................................
Patch Set 2: Code-Review+2
Let's wait for the rebase to pass but then it can go in.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2: Code-Review+2
Let's wait for the rebase to pass but then it can go in.
I approve of the rebase.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules ......................................................................
util/abuild/abuild: Do not check out submodules
This force-downloads the qc_blobs repository, whose license is then automatically accepted. This may also cause race conditions with git.
Change-Id: Id760172289abbe4d5ad5f230c9f1d3e1ab3908ec Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45607 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/abuild/abuild 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/abuild/abuild b/util/abuild/abuild index 7561495..2ba2f72 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -794,8 +794,6 @@ echo | xargs -P ${cpus:-0} -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1 fi
-git submodule update --checkout --init - if [ "$USE_XARGS" = "0" ]; then test "$MAKEFLAGS" == "" && test "$cpus" != "" && export MAKEFLAGS="-j $cpus" export MAKEFLAGS="$MAKEFLAGS UPDATED_SUBMODULES=1" # no need to re-download
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)