Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
cpu/x86/early_reset: Mark assemblycode as 32bit
Allows to compile the file under x86_64 without errors.
The caller has to make sure to call the functions while in protected mode, which is usually the case in early bootblock.
Change-Id: Ic6601e2af57e0acc6474fc3a4297e3d2281decd6 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/early_reset.S 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/48165/1
diff --git a/src/cpu/x86/early_reset.S b/src/cpu/x86/early_reset.S index 6ce9d52..07e63f4 100644 --- a/src/cpu/x86/early_reset.S +++ b/src/cpu/x86/early_reset.S @@ -7,6 +7,7 @@
#include <cpu/x86/mtrr.h>
+.code32 .section .text .global check_mtrr
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG@7 PS1, Line 7: assemblycode nit: assembly code
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG@7 PS1, Line 7: assemblycode
nit: assembly code
Done
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
cpu/x86/early_reset: Mark assemblycode as 32bit
Allows to compile the file under x86_64 without errors.
The caller has to make sure to call the functions while in protected mode, which is usually the case in early bootblock.
Change-Id: Ic6601e2af57e0acc6474fc3a4297e3d2281decd6 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48165 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/x86/early_reset.S 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/early_reset.S b/src/cpu/x86/early_reset.S index 6ce9d52..07e63f4 100644 --- a/src/cpu/x86/early_reset.S +++ b/src/cpu/x86/early_reset.S @@ -7,6 +7,7 @@
#include <cpu/x86/mtrr.h>
+.code32 .section .text .global check_mtrr
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48165 )
Change subject: cpu/x86/early_reset: Mark assemblycode as 32bit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48165/1//COMMIT_MSG@7 PS1, Line 7: assemblycode
Done
Not done, but it's too late now.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Rudolph (Code Review)