Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71236 )
Change subject: soc/intel: Create common function to check PCH slot
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/irq.h:
https://review.coreboot.org/c/coreboot/+/71236/comment/4f3365d2_9775832b
PS4, Line 69: /* Check if given slot is a PCH slot. */
consider adding more meaningful comment to explain how a PCH less SoC platform like MTL will still b […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fc850228b7ddbf84e2feb2433adff5e4002033
Gerrit-Change-Number: 71236
Gerrit-PatchSet: 5
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 12:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment