Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag ......................................................................
Makefile.inc: Remove the CBNT bootblock flag
At the moment this was only used for aligning the bootblock to 64 bytes. At the moment this automatically done with CONFIG_C_ENV_BOOTBLOCK_SIZE.
Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48468/1
diff --git a/Makefile.inc b/Makefile.inc index 420ce51..d95cb88 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -730,16 +730,6 @@
endif
-ifeq ($(CONFIG_INTEL_CBNT_SUPPORT),y) - -CBNTIBB := --cbnt - -else - -CBNTIBB := - -endif # CONFIG_INTEL_CBNT_SUPPORT - ifeq ($(CONFIG_COMPRESS_BOOTBLOCK),y)
$(objcbfs)/bootblock.lz4: $(objcbfs)/bootblock.elf $(objutil)/cbfstool/cbfs-compression-tool @@ -1081,7 +1071,6 @@ -n bootblock \ -t bootblock \ $(TXTIBB) \ - $(CBNTIBB) \ -b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes) \ $(TS_OPTIONS) else # ifeq ($(CONFIG_ARCH_X86),y)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag ......................................................................
Makefile.inc: Remove the CBNT bootblock flag
At the moment this was only used for aligning the bootblock to 64 bytes. At the moment this automatically done with CONFIG_C_ENV_BOOTBLOCK_SIZE.
Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/48468 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Christian Walter christian.walter@9elements.com --- M Makefile.inc 1 file changed, 0 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index dee4a2e..90280df 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -730,16 +730,6 @@
endif
-ifeq ($(CONFIG_INTEL_CBNT_SUPPORT),y) - -CBNTIBB := --cbnt - -else - -CBNTIBB := - -endif # CONFIG_INTEL_CBNT_SUPPORT - ifeq ($(CONFIG_COMPRESS_BOOTBLOCK),y)
$(objcbfs)/bootblock.lz4: $(objcbfs)/bootblock.elf $(objutil)/cbfstool/cbfs-compression-tool @@ -1085,7 +1075,6 @@ -n bootblock \ -t bootblock \ $(TXTIBB) \ - $(CBNTIBB) \ -b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes) \ $(TS_OPTIONS) \ $(CBFSTOOL_ADD_CMD_OPTIONS)